Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Equilibrium Extension #201
base: main
Are you sure you want to change the base?
Static Equilibrium Extension #201
Changes from all commits
8e2748a
f0e1cd2
7c0c4f5
a8a3130
4bd0306
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not obvious - in fact, I'd argue that carrying around the extra dimension in the shape makes it more difficult to interpret the arrays. AFAICT, the main reason for doing so is so that the
hstack
-ing works when constructing the system matrix. Instead of introducing the extra dimension at the beginning of the processing, I'd vote for simply adding a "dummy" dimension for the hstack, i.e. something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick ping on this one @h2o-DS - WDYT? If you don't have the bandwidth to make these updates but are not opposed to them, I'd be happy to push them up!