-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hugo to 0.115.4 #649
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jarrodmillman. These changes all seem useful, but I'd like to make sure that they won't cause problems for the imminent launch of the translated version of the site. We now have fully complete translations, and it seems to me that this may cause significant rework (not sure, I'm hoping @steppi can tell).
If there is a conflict, I'd much prefer to launch the Japanese and Portuguese translations first (should happen very soon), and then rebase this PR on top.
This branch, Currently, I created a copy of I think we should launch the translations first; it should be done this week. After that we can update hugo. |
Hugo 0.114 is forcing us to list non-standard parameters for each language under a
I will push a fix to the branch to make the site render correctly. |
@jarrodmillman, updated translations are in now. |
@steppi I hope I managed to preserve all the translation updates! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The rendered output for Portuguese and Japanese looks right to me just by comparing with what was there previously, @melissawm @AtsushiSakai. The formatting changes might cause Crowdin to lose translations for the translated yaml files, but if so, I know how to fix that.
@steppi If you are happy with this PR, please go ahead and merge it. I'm hesitant, since it may impinge on your work. |
Specifically, the structure of the |
Thanks, let me know if you need a hand in fixing up the others! |
Thanks @stefanv. I'm pretty sure this won't cause problems |
DO NOT MERGE UNTIL UPDATED TRANSLATIONS ARE MERGED
Depends on #639. See #649 (review).
Updating hugo in preparation for updating the theme. There were some changes in hugo 0.112 that are causing issues (addressed in e749f62) : https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120