Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T13-A2 #296

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

T13-A2 #296

wants to merge 4 commits into from

Conversation

gawsfbet
Copy link

Made code smelly

@okkhoy
Copy link

okkhoy commented Aug 25, 2016

@kevin-ong please rename the pull request in the correct format. I cannot identify who is this.

Acceptable now, but going forward submit one PR for one activity.

add the comment "ready for review" once you have renamed the PR

okkhoy
okkhoy reviewed Aug 28, 2016
View reviewed changes
src/seedu/addressbook/AddressBook.java
private static final String MESSAGE_ERROR_CREATING_STORAGE_FILE = "Error: unable to create file: %1$s";
private static final String MESSAGE_ERROR_MISSING_STORAGE_FILE = "Storage file missing: %1$s";
private static final String MESSAGE_ERROR_READING_FROM_FILE = "Unexpected error: unable to read from file: %1$s";
private static final String MESSAGE_ERROR_WRITING_TO_FILE = "Unexpected error: unable to write to file: %1$s";
Copy link

@okkhoy okkhoy Aug 28, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you messed up with the indentation; please check again?

@okkhoy okkhoy added Accepted and removed Accepted labels Aug 28, 2016
@mauris
Copy link

mauris commented Aug 28, 2016

Hi @kevin-ong, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.

Note that this comment is posted by a bot sorting all the pull request submissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FormatCheckRequested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gawsfbet @okkhoy @mauris