Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T2A3][T05-A3] Marx Low #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[T2A3][T05-A3] Marx Low #89

wants to merge 3 commits into from

Conversation

marxlow
Copy link

@marxlow marxlow commented Aug 23, 2016

Finished the task activities.

@mauris
Copy link

mauris commented Aug 28, 2016

Hi @marxlow, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.

Note that this comment is posted by a bot sorting all the pull request submissions.

yamgent pushed a commit to yamgent/addressbook-level1 that referenced this pull request Aug 5, 2018
…-AY1617S1#90)

The default storage file 'addressbook.txt' is not provided by default.
The program has to create a new storage file, and this process is 
written in the program's log.

Due to the additional information in the log, the first test run after 
cloning the master always result in failure, as the additional
information creates a difference between actual.txt and expected.txt,
causing the test to fail.

Let's add the default storage file 'addressbook.txt' into the test
folder so that the runtests.bat will stop failing on first run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants