[T6A1][F14-B1]Leon Mak #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanjunweimy
reviewed
Mar 6, 2017
| import seedu.addressbook.data.exception.IllegalValueException; | ||
| import seedu.addressbook.storage.Storage.StorageOperationException; | ||
|
|
||
| public abstract class Storage { |
There was a problem hiding this comment.
This class and its methods should have a header comments. If not, developers who needs to inherit from this class will not know how exactly they should override the methods and other developers who write client code for this class will not know how to use it either.
| } | ||
| } | ||
|
|
||
| public abstract void save(AddressBook addressBook) throws StorageOperationException; |
There was a problem hiding this comment.
It is better to give the method header comments in the parent class rather than the child class. The child class can inherit the comment from the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.