[T6A1][F12-B4]Huynh Van Tu An #519
Conversation
…y implementation but bad for performance
| import seedu.addressbook.data.AddressBook; | ||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
|
|
||
| public interface Storage { |
There was a problem hiding this comment.
This class and its methods should have header comments. If not, developers who need to inherit from this class will not know how exactly they should override the methods and other developers who write client code for this class will not know how to use it either.
| import seedu.addressbook.data.AddressBook; | ||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
|
|
||
| public interface Storage { |
There was a problem hiding this comment.
Based on the UML diagram in the exercise, this should be an abstract class, not an interface.
| @@ -151,4 +132,10 @@ public String getPath() { | |||
| return path.toString(); | |||
| } | |||
|
|
|||
| @Override | |||
| public Storage newStorage() throws InvalidStorageFilePathException{ | |||
| // TODO Auto-generated method stub | |||
There was a problem hiding this comment.
please remove such unnecessary comments.
| @@ -28,13 +28,13 @@ | |||
| @Rule | |||
| public TemporaryFolder saveFolder = new TemporaryFolder(); | |||
|
|
|||
| private StorageFile saveFile; | |||
| private Storage saveFile; | |||
There was a problem hiding this comment.
you need to use the storage stub here instead. something is not fully correct about this solution.
| public Storage newStorage() throws InvalidStorageFilePathException; | ||
| public Storage newStorage(String path) throws InvalidStorageFilePathException; | ||
| public static Storage newStorage() throws InvalidStorageFilePathException { | ||
| return new StorageFile(); |
There was a problem hiding this comment.
ouch! this is incorrect. can you think why?
|
@arishuynhvan |
|
@arishuynhvan @okkhoy Should our PRs be submitted as a team? |
|
@bryanleejh @arishuynhvan not this one. the v0.0 yes. |
|
@okkhoy @arishuynhvan okay! got it! |
Implement undo command instead of edit