Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PrismJS #1714

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Disable PrismJS #1714

merged 1 commit into from
Dec 28, 2024

Conversation

NotTheDr01ds
Copy link
Contributor

  • Disables the PrismJS highlighter entirely (I hope), setting Shiki as the highlighter for both VuePress and the theme.

  • CSV was apparently getting parsed through Prism previously, so this also adds the csv language to the Shiki config

  • And this changes the Shiki code-block theme from dark-plus to vitesse-dark. This does not appear to change any nu/nushell syntax highlighting, but it does enable proper ansi coloring.

This might finally explain why line-numbers were being applied by both Shiki and PrismJS previously.

@NotTheDr01ds NotTheDr01ds requested a review from hustcer December 28, 2024 04:56
@hustcer hustcer merged commit 44569f6 into nushell:main Dec 28, 2024
2 checks passed
@hustcer
Copy link
Collaborator

hustcer commented Dec 28, 2024

Thanks for the quick fix

@fdncred
Copy link
Collaborator

fdncred commented Dec 28, 2024

This does not appear to change any nu/nushell syntax highlighting,

definitely does for me. I don't recall green and pumpkin colored text like this. is there something closer to dark-plus that we can use?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants