Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ava): remove deprecated semantic pull request bot #1013

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/semantic.yml

This file was deleted.

5 changes: 0 additions & 5 deletions packages/cna-template/template/semantic.yml

This file was deleted.

1 change: 0 additions & 1 deletion packages/create-nuxt-app/lib/prompts.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ module.exports = [
type: 'checkbox',
choices: [
{ name: 'jsconfig.json (Recommended for VS Code if you\'re not using typescript)', value: 'jsconfig.json' },
{ name: 'Semantic Pull Requests', value: 'semantic-pull-requests' },
{ name: 'Dependabot (For auto-updating dependencies, GitHub only)', value: 'dependabot' }
],
default: []
Expand Down
2 changes: 0 additions & 2 deletions packages/create-nuxt-app/lib/saofile.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ module.exports = {
'_.prettierrc': 'linter.includes("prettier")',
'_jsconfig.json': 'devTools.includes("jsconfig.json")',
'tsconfig.json': 'language.includes("ts")',
'semantic.yml': 'devTools.includes("semantic-pull-requests")',
'_stylelint.config.js': 'linter.includes("stylelint")',
'_commitlint.config.js': 'linter.includes("commitlint")',
'dependabot.yml': 'devTools.includes("dependabot")'
Expand All @@ -134,7 +133,6 @@ module.exports = {
'_jsconfig.json': 'jsconfig.json',
'_stylelint.config.js': 'stylelint.config.js',
'_commitlint.config.js': 'commitlint.config.js',
'semantic.yml': '.github/semantic.yml',
'dependabot.yml': '.github/dependabot.yml'
}
})
Expand Down
86 changes: 1 addition & 85 deletions packages/create-nuxt-app/test/snapshots/index.test.js.md
Original file line number Diff line number Diff line change
Expand Up @@ -3661,14 +3661,13 @@ Generated by [AVA](https://avajs.dev).
}␊
`

## verify devTools: jsconfig.json (Recommended for VS Code if you're not using typescript), Semantic Pull Requests, Dependabot (For auto-updating dependencies, GitHub only)
## verify devTools: jsconfig.json (Recommended for VS Code if you're not using typescript), Dependabot (For auto-updating dependencies, GitHub only)

> Generated files

[
'.editorconfig',
'.github/dependabot.yml',
'.github/semantic.yml',
'.gitignore',
'README.md',
'components/NuxtLogo.vue',
Expand Down Expand Up @@ -3829,89 +3828,6 @@ Generated by [AVA](https://avajs.dev).
}␊
`

## verify devTools: Semantic Pull Requests

> Generated files

[
'.editorconfig',
'.github/semantic.yml',
'.gitignore',
'README.md',
'components/NuxtLogo.vue',
'components/Tutorial.vue',
'nuxt.config.js',
'package.json',
'pages/index.vue',
'static/favicon.ico',
'store/README.md',
]

> package.json

{
dependencies: {
'core-js': '^3.25.3',
nuxt: '^2.15.8',
vue: '^2.7.10',
'vue-server-renderer': '^2.7.10',
'vue-template-compiler': '^2.7.10',
},
devDependencies: {},
private: true,
scripts: {
build: 'nuxt build',
dev: 'nuxt',
generate: 'nuxt generate',
start: 'nuxt start',
},
}

> Generated nuxt.config.js

`export default {␊
// Global page headers: https://go.nuxtjs.dev/config-head␊
head: {␊
title: 'output',␊
htmlAttrs: {␊
lang: 'en'␊
},␊
meta: [␊
{ charset: 'utf-8' },␊
{ name: 'viewport', content: 'width=device-width, initial-scale=1' },␊
{ hid: 'description', name: 'description', content: '' },␊
{ name: 'format-detection', content: 'telephone=no' }␊
],␊
link: [␊
{ rel: 'icon', type: 'image/x-icon', href: '/favicon.ico' }␊
]␊
},␊
// Global CSS: https://go.nuxtjs.dev/config-css␊
css: [␊
],␊
// Plugins to run before rendering page: https://go.nuxtjs.dev/config-plugins␊
plugins: [␊
],␊
// Auto import components: https://go.nuxtjs.dev/config-components␊
components: true,␊
// Modules for dev and build (recommended): https://go.nuxtjs.dev/config-modules␊
buildModules: [␊
],␊
// Modules: https://go.nuxtjs.dev/config-modules␊
modules: [␊
],␊
// Build Configuration: https://go.nuxtjs.dev/config-build␊
build: {␊
}␊
}␊
`

## verify devTools: Dependabot (For auto-updating dependencies, GitHub only)

> Generated files
Expand Down
Binary file modified packages/create-nuxt-app/test/snapshots/index.test.js.snap
Binary file not shown.