Fix audio output device selection

[SaschaCowley]

Link to issue number:

Fixes #17530

Summary of the issue:

With the switch to exclusively WASAPI, selecting among more than 2 output devices did not work properly.

Description of user facing changes

Selection of output devices should now be more reliable.

Description of development approach

Fixed up the check for whether the selected device is the default output device. Also removed some unneeded initialisation parameters and constants.

Testing strategy:

Manually tested switching between 3 output devices (plus default), with various devices set as the Windows and NVDA default.

Known issues with pull request:

Some legacy winmm code remains, but this will be removed once SAPI4 support has been fixed.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary

[jcsteh]

While we're removing things, is it worth renaming WasapiWavePlayer to just WavePlayer as well, thus removing the redundant alias? The fact that it's called WasapiWavePlayer was an internal implementation detail necessitated by the coexistence of WinMM and WASAPI. In hindsight, I probably should have underscore prefixed it in the first place.

[SaschaCowley]

@jcsteh yes, I think we should. I'm planning to do this in the new year.

[seanbudd]

@SaschaCowley - I think this also missed being announced on the API mailing list