Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Java Access Bridge calls to fix NVDA crashes when selecting whole text in specific source files in Android studio #17604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thgcode
Copy link
Contributor

@thgcode thgcode commented Jan 10, 2025

Link to issue number:

fixes #17418

Summary of the issue:

Nvda crashes when selecting whole text in specific source files in Android Studio and IntelliJ Idea

Description of user facing changes

NVDA should no longer crash.

Description of development approach

Java Access Bridge has a buffer limit of 10240 characters for the text. If the text is too large to fit on this buffer size, NVDA will split the calls to take the buffer size in account.

Testing strategy:

Tested with IntelliJ idea and the file provided on the issue.

Known issues with pull request:

No known issues were identified.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@AppVeyorBot
Copy link

See test results for failed build of commit c545bb5896

Summary of the issue:
Nvda crashes when selecting whole text in specific source files in Android Studio and IntelliJ Idea

Description of user facing changes
NVDA should no longer crash.

Description of development approach
Java Access Bridge has a buffer limit of 10240 characters for the text. If the text is too large to fit on this buffer size, NVDA will split the calls to take the buffer size in account.
@thgcode thgcode force-pushed the fix/java-access-bridge-crash branch from 5341d7e to 6973d4d Compare January 10, 2025 01:11
@thgcode thgcode marked this pull request as ready for review January 10, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nvda crashes when selecting whole text in specific source files in Android studio
2 participants