Implement an extension point deprecation strategy #17644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up of #17011
Slightly related to #17635, as this oversight was found there
Summary of the issue:
In #17011,
braille.filter_displaySize
was deprecated, but there was not yet a mechanism in place that logs warnings about usage of the deprecated extension point.Description of user facing changes
Warnings in the log when
braille.filter_displaySize.register
is called.Description of development approach
filter_displayDimensions
filter_displayDimensions
Testing strategy:
Tested that a warning is logged when registering
Known issues with pull request:
None known
Code Review Checklist:
@coderabbitai summary