feat(filesystem): Implement shared clipboard #1594
Conversation
|
Fixed it! |
| log.error("Failed to save clipboard. JSON serialization error") | ||
| return | ||
| end | ||
| file:write(data) |
There was a problem hiding this comment.
I actually meant to put the error handling n the file:write / file:flush code. That's where you are going to get frequent errors due to permissions, file locked, disk full, etc.
|
|
||
| -- Using watch_folder because we haven't "watch_file" :) | ||
| fs_watch.watch_folder(clipboard_state_dir_path, function() | ||
| if not clipboard_file_change_triggered_by_cur_neovim_instance then |
There was a problem hiding this comment.
This is a bad idea. You can't say for sure that a file event came from this instance just because you wrote a file recently. This is fertile ground for hard to recreate bugs.
Between this and the modified time based check I would rather use the first solution where you just process every write, even your own.
I think I have a better idea:
- When you convert the clipboard to json, save the json string as
last_clipboard_saved - When you read in a new changed file event, compare the contents of the changed file to the
last_clipboard_saved - If they are equal, nil out the
last_clipboard_savedand ignore the event.
There was a problem hiding this comment.
Actually I can't understand why we can't be sure about this. Can you give me an example, please?
- The variable
clipboard_file_change_triggered_by_cur_neovim_instanceis set in thesave_clipboardfunction after writing the clipboard to the file - After that an event is immediately triggered in response to the file change.
Why can't we be sure that the write occurred in the current instance? We are not performing any other actions between these two steps, are we?
There was a problem hiding this comment.
We do not have exclusive access to this folder. Another program could write a file in this folder for some reason.
For that matter, neo-tree itself might write a file here. It doesn't do that now, but someone else may do so in the future and they likely won't know that some other section of the code is naively reading every file written without checking the contents or even the file name.
Finally, I don't think you should be so confident about the order of events when you are dealing with asynchronous actions.
| return clipboard | ||
| end | ||
|
|
||
| M._update_all_cilpboards = function(clipboard) |
There was a problem hiding this comment.
Typo:
| M._update_all_cilpboards = function(clipboard) | |
| M._update_all_clipboards = function(clipboard) |
|
any updates on this ? |
This pull request aims to solve #1301 issue by adding the shared_clipboard functionality
And it also probably solves these two:
#168
#1235
You can watch how it works here:
shared_clipboard_preview.mp4