-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add many icons, use official git colour #447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change git color to #f54d27 - Use same icons for cfg, conf and ini files - Add tmux config files - Add Tux icons to `a`, `ko` and `so` files - Add Android icon to `android` and `apk` files - Add down arrow icon for some download files - Add library icon for `dll` and `lib` files - Add Emacs icons for `el`, `elc` and `eln` files - Add also env icon for `.env` files - Add calendar icon for some files - Add bin icons for `o` files - Add +- icon for `diff` and `patch` files - Add icon for `signature` file
alex-courtis
requested changes
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small changes only.
λ
is not part of nerd fonts however it can be addressed during #418
feat: add some icons dowload - Change git color to #f54d27 - Use same icons for cfg, conf and ini files - Add tmux config files - Add Tux icons to `a`, `ko` and `so` files - Add Android icon to `android` and `apk` files - Add down arrow icon for some download files - Add library icon for `dll` and `lib` files - Add Emacs icons for `el`, `elc` and `eln` files - Add also env icon for `.env` files - Add calendar icon for some files - Add bin icons for `o` files - Add +- icon for `diff` and `patch` files - Add icon for `signature` file
feat: add some icons Emacs - Change git color to #f54d27 - Use same icons for cfg, conf and ini files - Add tmux config files - Add Tux icons to `a`, `ko` and `so` files - Add Android icon to `android` and `apk` files - Add down arrow icon for some download files - Add library icon for `dll` and `lib` files - Add Emacs icons for `el`, `elc` and `eln` files - Add also env icon for `.env` files - Add calendar icon for some files - Add bin icons for `o` files - Add +- icon for `diff` and `patch` files - Add icon for `signature` file
alex-courtis
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your fine contribution!
alex-courtis
changed the title
feat: add some icons
feat: add many icons, use official git colour
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a
,ko
andso
filesandroid
andapk
filesdll
andlib
filesel
,elc
andeln
files.env
fileso
filespatch
extension but it seems thatdiff
file is usingnf-dev-git_compare
. I think it's better to usenf-oct-diff
in both extensions.signature
file but it seems thatsig
file is using λ U+03BB I think it's better to usenf-md-file_sign
in both extensions.