Skip to content

Commit

Permalink
DevTools: fix date with version, image for What's New
Browse files Browse the repository at this point in the history
* Use a customizable header string
* Make png smaller

BUG=682879

Review-Url: https://codereview.chromium.org/2813303004
Cr-Commit-Position: refs/heads/master@{#464662}
(cherry picked from commit 629219e)

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2834473002
Cr-Commit-Position: refs/branch-heads/3071@{#66}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
  • Loading branch information
wwwillchen authored and Commit bot committed Apr 19, 2017
1 parent dd75799 commit 435d20f
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Last release note version seen:
0

Dumping release note text:
Highlights from March 2017 update
Highlights from Chrome 100 update
Improved Performance and Memory panels
Edit cookies directly from the Application panel
LEARN MORECLOSE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
Help.releaseNoteText = [
{
version: 99,
date: "March 2017",
header: 'Highlights from Chrome 100 update',
highlights: [
{
title: 'Improved Performance and Memory panels',
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion third_party/WebKit/Source/devtools/front_end/help/Help.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Help._releaseNoteViewId = 'release-note';
Help.ReleaseNoteHighlight;

/**
* @typedef {!{version: number, date: string, highlights: !Array<!Help.ReleaseNoteHighlight>,
* @typedef {!{version: number, header: string, highlights: !Array<!Help.ReleaseNoteHighlight>,
* link: string}}
*/
Help.ReleaseNote;
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var commandMenuShortcut = Host.isMac() ? 'Command + Shift + P' : 'Control + Shif
Help.releaseNoteText = [
{
version: 2,
date: 'April 2017',
header: 'Highlights from Chrome 59 update',
highlights: [
{
title: 'CSS and JS code coverage',
Expand Down Expand Up @@ -49,7 +49,7 @@ Help.releaseNoteText = [
},
{
version: 1,
date: 'March 2017',
header: 'Highlights from Chrome 58 update',
highlights: [
{
title: 'New Performance and Memory panels',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Help.ReleaseNoteView = class extends UI.VBox {
this.registerRequiredCSS('help/releaseNote.css');
var releaseNoteElement = this._createReleaseNoteElement(Help.latestReleaseNote());
var topSection = this.contentElement.createChild('div', 'release-note-top-section');
topSection.textContent = Common.UIString(`Highlights from ${Help.latestReleaseNote().date} update`);
topSection.textContent = Common.UIString(Help.latestReleaseNote().header);
this.contentElement.appendChild(releaseNoteElement);
}

Expand Down

0 comments on commit 435d20f

Please sign in to comment.