Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove over-invalidation of LayoutView on overflow recomputation.
r581008 added a call to SetNeedsCompositingInputsUpdate in LayoutView whenever overflow needed to be recomputed. It actually only needs to do that when overflow actually changes. This regresses any site which causes LayoutView overflow recomputation during animations. The call to SetNeedsCompositingInputsUpdate already exists in LayoutBlock::ComputeOverflow, and correctly only does it when overflow changes. An example is tools/perf/page_sets/key_silk_cases/pushState.html, which was one of the key silk sites that regressed in issue 872172. In that case, main frame times approximately doubled, because of the extra work to compute compositing inputs. crbug.com/872172 [email protected] (cherry picked from commit d1042cc) Change-Id: Iaf4780c0e3ed4d8df67d16d836486df6df0d2f43 Reviewed-on: https://chromium-review.googlesource.com/1200315 Reviewed-by: vmpstr <[email protected]> Commit-Queue: Chris Harrelson <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#588205} Reviewed-on: https://chromium-review.googlesource.com/1208436 Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#66} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
- Loading branch information