Skip to content

Commit

Permalink
Hotfix: hasText value is incorrectly set
Browse files Browse the repository at this point in the history
Following the refactoring in CL: 2694543002 the value of hasText is incorrectly
set. To be precise, hasText is always set to the negate of its correct value.

BUG=602427

Review-Url: https://codereview.chromium.org/2735633005
Cr-Commit-Position: refs/heads/master@{#454901}
(cherry picked from commit 6e3e9e5)

Review-Url: https://codereview.chromium.org/2741503002 .
Cr-Commit-Position: refs/branch-heads/3029@{#66}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
  • Loading branch information
ehsan-karamad committed Mar 8, 2017
1 parent e63f1c2 commit aab5ba0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3422,7 +3422,7 @@ - (id)validRequestorForSendType:(NSString*)sendType
BOOL returnTypeIsString = [returnType isEqual:NSStringPboardType];
const content::TextInputManager::TextSelection* selection =
renderWidgetHostView_->GetTextSelection();
BOOL hasText = !selection || selection->selected_text().empty();
BOOL hasText = selection && !selection->selected_text().empty();
BOOL takesText =
renderWidgetHostView_->GetTextInputType() != ui::TEXT_INPUT_TYPE_NONE;

Expand Down

0 comments on commit aab5ba0

Please sign in to comment.