Temba Chat #673
Merged
Temba Chat #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
+ Coverage 74.39% 74.44% +0.05%
==========================================
Files 97 98 +1
Lines 13085 13119 +34
==========================================
+ Hits 9734 9767 +33
- Misses 2662 2663 +1
Partials 689 689 ☔ View full report in Codecov by Sentry. |
norkans7
reviewed
Jan 11, 2024
| } | ||
|
|
||
| func setSendURL(s *httptest.Server, h courier.ChannelHandler, c courier.Channel, m courier.MsgOut) { | ||
| defaultSendURL = s.URL |
There was a problem hiding this comment.
I think it i better to set the config send URL here and remove defaultSendURL
There was a problem hiding this comment.
I'm just copying how other handlers are done but I did wonder if all handlers should support send_url in config and then this can be the normal way of overriding it in tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs some kind of token based security