tweaked some English grammar #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaked some English. Review to be sure corrections didn't impede meaning.
mzanetti
requested changes
Nov 16, 2022
| the ui to be used for this [ThingClass](/documentation/developers/integrations/thing-class#interfaces). For example, having a plugin that can control a dimmable light would likely have a | ||
| state named "powered" of type boolean and one named "brightness" of type int, ranging from 0 to 100%. Having just this | ||
| information, the ui would create a generic switch component to flip the bool state and a generic slider component to | ||
| that the UI (User Interface) be used for this [ThingClass](/documentation/developers/integrations/thing-class#interfaces). For example, having a plugin that can control a dimmable light would likely have a |
There was a problem hiding this comment.
I'm not a native english speaker, but this doesn't sound right to me.
So the way it works is that if a plugin developer for example specifies the "light" interface, nymea:app would pick the UI for lights, if a plugin developer specifies the thermostat interface, nymea:app would pick the thermostat UI for the device.
|
|
||
| A interface can extend another interface. For example, the light interface only requires one state called powered of type bool. | ||
| An interface can extend another interface. For example, the light interface only requires one state called _powered off type bool_. |
There was a problem hiding this comment.
the light interface requires one state. The states name is "power" and the states type is "bool". So it seems the change from "of" to "off" as well as making the whole thing italic (with the underscores) wasn't right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked some English. Review to be sure corrections didn't impede meaning.