Merge PR #194: Modbuscommander: Update network device discovery

nymea · Dec 18, 2024 · 054aa47 · 054aa47
2 parents 842a968 + 29a9e17
commit 054aa47
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/modbuscommander/integrationpluginmodbuscommander.cpp b/modbuscommander/integrationpluginmodbuscommander.cpp
@@ -130,10 +130,15 @@ void IntegrationPluginModbusCommander::discoverThings(ThingDiscoveryInfo *info)
                 }
 
                 QString description;
-                if (networkDeviceInfo.macAddressManufacturer().isEmpty()) {
-                    description = networkDeviceInfo.macAddress();
+                MacAddressInfo macInfo = networkDeviceInfo.macAddressInfos().constFirst();
+                description = networkDeviceInfo.address().toString();
+                if (!macInfo.vendorName().isEmpty())
+                    description += " - " + networkDeviceInfo.macAddressInfos().constFirst().vendorName();
+
+                if (networkDeviceInfo.hostName().isEmpty()) {
+                    title = macInfo.macAddress().toString();
                 } else {
-                    description = networkDeviceInfo.macAddress() + " (" + networkDeviceInfo.macAddressManufacturer() + ")";
+                    title = networkDeviceInfo.hostName() + " (" + macInfo.macAddress().toString() + ")";
                 }
 
                 ThingDescriptor descriptor(modbusTCPClientThingClassId, title, description);