Lawrence/ev sign #1642
Lawrence/ev sign #1642
Conversation
Testing real signature this time more testing better credential id Test signature changed from sed to yq ..
| "signCommand": { | ||
| "cmd": "C:\Program Files\Git\bin\bash.EXE", | ||
| "args": [ | ||
| "/c/actions-runner/_work/nym-vpn-client/nym-vpn-client/nym-vpn-app/src-tauri/CodeSignTool.sh", |
There was a problem hiding this comment.
Wonder if we can rely on $GITHUB_WORKSPACE to obtain the /c/actions-runner/_work/nym-vpn-client/ part and AFAIK even if it's windows path, bash.exe should probably understand it right?
There was a problem hiding this comment.
No we can't.
${{ github.workspace }} give a path in the form of C:\action-runner\_work\nym-vpn-client since we're in windows.
Since we're running in bash, \n get interpreted as a line return.
| NETWORK_ENV_SELECT: ${{ inputs.dev_mode == true }} | ||
| CODE_SIGN_TOOL_PATH: "C:\\actions-runner\\_work\\nym-vpn-client\\nym-vpn-client\\nym-vpn-app\\src-tauri\\" |
There was a problem hiding this comment.
Same here, maybe use ${{ github.workspace }} to obtain the prefix?
There was a problem hiding this comment.
No we can't.
${{ github.workspace }} give a path in the form of C:\action-runner\_work\nym-vpn-client since we're in windows.
Since we're running in bash, \n get interpreted as a line return.
| run: | | ||
| npm run tauri info |
There was a problem hiding this comment.
Nop, not needed, forgot about it.
|
wp @Bykow ;) |
Signing for windows app with SSL.com ev signer
This change is