chore: apply 1.84 linter suggestions

Cargo.toml

@@ -394,19 +394,17 @@ prost = { version = "0.12", default-features = false }
 
 # wasm-related dependencies
 gloo-utils = "0.2.0"
-gloo-net = "0.5.0"
+gloo-net = "0.6.0"
 
-# use a separate branch due to feature unification failures
-# this is blocked until the upstream removes outdates `wasm_bindgen` feature usage
-# indexed_db_futures = "0.4.1"
-indexed_db_futures = { git = "https://github.com/TiemenSch/rust-indexed-db", branch = "update-uuid" }
-js-sys = "0.3.70"
+# TODO: migrate to 0.6+
+indexed_db_futures = "0.4.2"
+js-sys = "0.3.76"
 serde-wasm-bindgen = "0.6.5"
 tsify = "0.4.5"
-wasm-bindgen = "0.2.95"
-wasm-bindgen-futures = "0.4.45"
-wasmtimer = "0.2.0"
-web-sys = "0.3.72"
+wasm-bindgen = "0.2.99"
+wasm-bindgen-futures = "0.4.49"
+wasmtimer = "0.4.1"
+web-sys = "0.3.76"
 
 # Profile settings for individual crates
 

common/client-core/src/init/helpers.rs

@@ -190,7 +190,7 @@ where
     Ok(GatewayWithLatency::new(gateway, avg))
 }
 
-pub async fn choose_gateway_by_latency<'a, R: Rng, G: ConnectableGateway + Clone>(
+pub async fn choose_gateway_by_latency<R: Rng, G: ConnectableGateway + Clone>(
     rng: &mut R,
     gateways: &[G],
     must_use_tls: bool,

common/gateway-requests/src/registration/handshake/client.rs

@@ -9,7 +9,7 @@ use futures::{Sink, Stream};
 use rand::{CryptoRng, RngCore};
 use tungstenite::Message as WsMessage;
 
-impl<'a, S, R> State<'a, S, R> {
+impl<S, R> State<'_, S, R> {
     async fn client_handshake_inner(&mut self) -> Result<(), HandshakeError>
     where
         S: Stream<Item = WsItem> + Sink<WsMessage> + Unpin,

common/gateway-requests/src/registration/handshake/gateway.rs

@@ -10,7 +10,7 @@ use crate::registration::handshake::{error::HandshakeError, WsItem};
 use futures::{Sink, Stream};
 use tungstenite::Message as WsMessage;
 
-impl<'a, S, R> State<'a, S, R> {
+impl<S, R> State<'_, S, R> {
     async fn gateway_handshake_inner(
         &mut self,
         raw_init_message: Vec<u8>,

common/nym_offline_compact_ecash/src/scheme/aggregation.rs

@@ -115,10 +115,7 @@ pub fn aggregate_signatures(
     let params = ecash_group_parameters();
     // aggregate the signature
 
-    let signature = match Aggregatable::aggregate(signatures, indices) {
-        Ok(res) => res,
-        Err(err) => return Err(err),
-    };
+    let signature = Aggregatable::aggregate(signatures, indices)?;
 
     // Ensure the aggregated signature is not an infinity point
     if bool::from(signature.is_at_infinity()) {

common/statistics/src/clients/packet_statistics.rs

@@ -428,7 +428,7 @@ impl PacketStatisticsControl {
         while self
             .history
             .front()
-            .map_or(false, |&(t, _)| t < recording_window)
+            .is_some_and(|&(t, _)| t < recording_window)
         {
             self.history.pop_front();
         }
@@ -462,7 +462,7 @@ impl PacketStatisticsControl {
         while self
             .rates
             .front()
-            .map_or(false, |&(t, _)| t < recording_window)
+            .is_some_and(|&(t, _)| t < recording_window)
         {
             self.rates.pop_front();
         }

explorer-api/src/gateways/models.rs

@@ -120,9 +120,7 @@ impl ThreadsafeGatewayCache {
             .read()
             .await
             .get(&identity_key)
-            .map_or(false, |cache_item| {
-                cache_item.valid_until > SystemTime::now()
-            })
+            .is_some_and(|cache_item| cache_item.valid_until > SystemTime::now())
     }
 
     pub(crate) async fn get_locations(&self) -> GatewayLocationCache {

explorer-api/src/mix_nodes/models.rs

@@ -106,9 +106,7 @@ impl ThreadsafeMixNodesCache {
             .read()
             .await
             .get(&mix_id)
-            .map_or(false, |cache_item| {
-                cache_item.valid_until > SystemTime::now()
-            })
+            .is_some_and(|cache_item| cache_item.valid_until > SystemTime::now())
     }
 
     pub(crate) async fn get_locations(&self) -> MixnodeLocationCache {

explorer-api/src/unstable/models.rs

@@ -60,9 +60,7 @@ impl ThreadSafeNymNodesCache {
             .read()
             .await
             .get(&node_id)
-            .map_or(false, |cache_item| {
-                cache_item.valid_until > SystemTime::now()
-            })
+            .is_some_and(|cache_item| cache_item.valid_until > SystemTime::now())
     }
 
     pub(crate) async fn get_bonded_nymnodes(

nym-credential-proxy/nym-credential-proxy/src/http/state/mod.rs

@@ -710,7 +710,7 @@ pub(crate) struct ChainWritePermit<'a> {
     inner: RwLockWriteGuard<'a, DirectSigningHttpRpcNyxdClient>,
 }
 
-impl<'a> ChainWritePermit<'a> {
+impl ChainWritePermit<'_> {
     pub(crate) async fn make_deposits(
         self,
         short_sha: &'static str,

tools/internal/testnet-manager/src/manager/dkg_skip.rs

@@ -168,9 +168,9 @@ impl NetworkManager {
         Ok(())
     }
 
-    async fn validate_existing_contracts<'a>(
+    async fn validate_existing_contracts(
         &self,
-        ctx: &DkgSkipCtx<'a>,
+        ctx: &DkgSkipCtx<'_>,
     ) -> Result<ContractCodeId, NetworkManagerError> {
         ctx.println(format!(
             "🔬 {}Validating the current DKG and group contracts...",
@@ -215,9 +215,9 @@ impl NetworkManager {
         Ok(current_code)
     }
 
-    async fn persist_dkg_keys<'a, P: AsRef<Path>>(
+    async fn persist_dkg_keys<P: AsRef<Path>>(
         &self,
-        ctx: &mut DkgSkipCtx<'a>,
+        ctx: &mut DkgSkipCtx<'_>,
         output_dir: P,
     ) -> Result<(), NetworkManagerError> {
         ctx.println(format!(
@@ -272,9 +272,9 @@ impl NetworkManager {
         Ok(())
     }
 
-    async fn upload_bypass_contract<'a, P: AsRef<Path>>(
+    async fn upload_bypass_contract<P: AsRef<Path>>(
         &self,
-        ctx: &DkgSkipCtx<'a>,
+        ctx: &DkgSkipCtx<'_>,
         dkg_bypass_contract: P,
     ) -> Result<ContractCodeId, NetworkManagerError> {
         ctx.println(format!(
@@ -297,9 +297,9 @@ impl NetworkManager {
         Ok(res.code_id)
     }
 
-    async fn migrate_to_bypass_contract<'a>(
+    async fn migrate_to_bypass_contract(
         &self,
-        ctx: &DkgSkipCtx<'a>,
+        ctx: &DkgSkipCtx<'_>,
         code_id: ContractCodeId,
     ) -> Result<(), NetworkManagerError> {
         ctx.println(format!(
@@ -336,9 +336,9 @@ impl NetworkManager {
         Ok(())
     }
 
-    async fn restore_dkg_contract<'a>(
+    async fn restore_dkg_contract(
         &self,
-        ctx: &DkgSkipCtx<'a>,
+        ctx: &DkgSkipCtx<'_>,
         code_id: ContractCodeId,
     ) -> Result<(), NetworkManagerError> {
         ctx.println(format!(
@@ -363,7 +363,7 @@ impl NetworkManager {
         Ok(())
     }
 
-    async fn add_group_members<'a>(&self, ctx: &DkgSkipCtx<'a>) -> Result<(), NetworkManagerError> {
+    async fn add_group_members(&self, ctx: &DkgSkipCtx<'_>) -> Result<(), NetworkManagerError> {
         ctx.println(format!(
             "👪 {}Adding all the cw4 group members...",
             style("[7/8]").bold().dim()
@@ -387,9 +387,9 @@ impl NetworkManager {
         Ok(())
     }
 
-    async fn transfer_signer_tokens<'a>(
+    async fn transfer_signer_tokens(
         &self,
-        ctx: &DkgSkipCtx<'a>,
+        ctx: &DkgSkipCtx<'_>,
     ) -> Result<(), NetworkManagerError> {
         ctx.println(format!(
             "💸 {}Transferring tokens to the new signers...",

tools/internal/testnet-manager/src/manager/local_apis.rs

@@ -67,9 +67,9 @@ impl NetworkManager {
             .join(DEFAULT_CONFIG_FILENAME)
     }
 
-    async fn initialise_api<'a>(
+    async fn initialise_api(
         &self,
-        ctx: &LocalApisCtx<'a>,
+        ctx: &LocalApisCtx<'_>,
         info: &EcashSignerWithPaths,
     ) -> Result<(), NetworkManagerError> {
         let address = &info.data.cosmos_account.address;
@@ -139,7 +139,7 @@ impl NetworkManager {
         Ok(())
     }
 
-    async fn initialise_apis<'a>(&self, ctx: &LocalApisCtx<'a>) -> Result<(), NetworkManagerError> {
+    async fn initialise_apis(&self, ctx: &LocalApisCtx<'_>) -> Result<(), NetworkManagerError> {
         ctx.println(format!(
             "🔏 {}Initialising local nym-apis...",
             style("[1/1]").bold().dim()