Add config page for school forms, add default search date config points #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is only to make the dates configurable. There are other issues in this code which need to be addressed in the future. |
fksaintil
approved these changes
Oct 23, 2024
|
Moving towards refactor of this section. |
routinet
deleted the
feature/nys-16696--create-config-point-for-event-dates
branch
routinet
restored the
feature/nys-16696--create-config-point-for-event-dates
branch
nathanielwoodland
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Code looks good @routinet. However, I'm not 100% clear on the business need here, so I can't properly scrutinize if this is the best way to achieve the desired end result in Drupal (but maybe you don't need me scrutinizing everything you do!)
routinet
deleted the
feature/nys-16696--create-config-point-for-event-dates
branch
|
@nathanielwoodland all good.. we know this isn't the best. This is a stop-gap, which also provided the impetus to spin up NYS-83 again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.