Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update email tfa to 2.0.3 - security update #272

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Update email tfa to 2.0.3 - security update #272

merged 4 commits into from
Jan 22, 2025

Conversation

aheaphy
Copy link
Contributor

@aheaphy aheaphy commented Jan 8, 2025

No description provided.

@fksaintil fksaintil added the testing PR is current being tested label Jan 13, 2025
@fksaintil fksaintil removed the testing PR is current being tested label Jan 21, 2025
nathanielwoodland
nathanielwoodland approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@nathanielwoodland nathanielwoodland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! (With the usual caveat that I can't verify TFA flow from the code alone.)

Also, nice to see the dashboard redirection logic moved into the NYS Dashboard module.

@fksaintil fksaintil added the ready Tested and ready for deployment (unless on-hold) label Jan 21, 2025
@routinet routinet merged commit 067ac16 into main Jan 22, 2025
2 checks passed
@routinet routinet deleted the feature/nys-16889--emailtfa branch January 22, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielwoodland nathanielwoodland nathanielwoodland approved these changes

Assignees
No one assigned
Labels
ready Tested and ready for deployment (unless on-hold)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aheaphy @nathanielwoodland @routinet @fksaintil