Fix compatibility issue with React Native environment #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tizmagik
approved these changes
May 25, 2023
|
Great, thank you! 🙏 👍 Just out of curiosity, when can we expect the next release of the library with the recent changes to be published on NPM? Much appreciated! |
|
Released in v9.3.2 |
|
Amazing! Thank you very much 👍 🙏 |
|
What version of React/React Native are you on? I am seeing this error when using |
|
@anna-rusk that looks like a different error entirely. Mind opening up a new issue with more context? Thanks. |
|
I had this issue open! It was closed recently but I am still facing this issue - I will post more context there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve the compatibility with React Native and ensure the dispatch function is triggered correctly.
Currently, the code assumes the availability of the "window" object without checking its type, which is causing an issue with the dispatch function in React Native where "window" is not present. 🙅♂️
To fix this, I have added a simple check to ensure the "window" object is defined using typeof window === "undefined". This allows the code to gracefully handle React Native environments and ensures the dispatch function works smoothly in web browser environments. 🚀
Thank you so much for your time and consideration. 🙏