Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nyxx_lavalink to use nyxx 6.0.0 and Lavalink v4 #16

Merged
merged 28 commits into from
Dec 9, 2023

Conversation

abitofevrything
Copy link
Member

Description

This PR is a complete rewrite of nyxx_lavalink that updates nyxx to 6.0.0 and Lavalink to v4. It uses nyxx's plugin system, simplifies the Lavalink connection logic and harmonises the API to be more similar to the 6.0.0 nyxx API.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the enhancement New feature or request label Dec 9, 2023
@abitofevrything abitofevrything added this to the 4.0.0 milestone Dec 9, 2023
@abitofevrything abitofevrything self-assigned this Dec 9, 2023
@abitofevrything abitofevrything merged commit 1b7137a into next Dec 9, 2023
4 of 6 checks passed
@abitofevrything abitofevrything mentioned this pull request Dec 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Ready for deploy
Development

Successfully merging this pull request may close these issues.

2 participants