-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Add support to build bindings using mina as a submodule in o1js repo #159
Merged
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ba291fc
feat: change dune and cargo to build mina as a submodule
MartinMinkov cb91aa9
feat: copy config files from mina submodule and change paths
MartinMinkov 26723fd
fix(test_vectors): update paths to crypto/proof-systems in dump-test-…
MartinMinkov 2ca7383
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov 469231d
refactor(dune): update relative paths for proof-systems and kimchi_bi…
MartinMinkov 631edb5
fix(build-snarkyjs-web.sh, update-snarkyjs-bindings.sh): change SNARK…
MartinMinkov 3f2ccd8
fix(dump-test-vectors.sh): change 'b10' to 'hex' in cargo run command…
MartinMinkov 634f2ab
feat(kimchi): remove kimchi, since it's been moved to mina repo
MartinMinkov 6529e3d
feat: support compiling kimchi from mina repo
MartinMinkov a702f05
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov 98eb83e
fix(lint.yaml): remove redundant prettier check
MartinMinkov 7ea6187
fix(CODEOWNERS): remove kimchi directory from CODEOWNERS file as it n…
MartinMinkov c111dca
docs(README.md): remove '/kimchi' directory description as it is no l…
MartinMinkov 7cffd8b
feat: fix scripts for o1js building
MartinMinkov a1c20d5
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov 4b453f0
chore: update bindings
MartinMinkov 05d5665
feat(build-snarkyjs-node-artifacts.sh): add dune build command for co…
MartinMinkov 225dd0a
chore: update bindings
MartinMinkov 9669d55
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov 58d78b5
move kimchi/{wasm,js} to kimchi_bindings
mitschabaude b30b566
Merge branch 'main' into feat/mina-submodule-support
mitschabaude dd2e7e9
fix build scripts
mitschabaude 15b2761
add script to help with dune build
mitschabaude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,4 +15,3 @@ jobs: | |
run: | | ||
npm init -y | ||
npm i prettier | ||
npx prettier -c kimchi/js/**/*.js js/**/*.js |
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
/CODEOWNERS @bkase @mitschabaude @mrmr1993 | ||
/kimchi @o1-labs/crypto-eng-reviewers | ||
. @o1-labs/eng |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
The mina commit used to generate the backends for node and web is | ||
40897ede7b1adb595d51c43ba84f05e0e17dd08d | ||
e6fceba0b16e95824f89b553d821a60fcd5f72bd |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the instructions in the README has to be changed.