Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Add support to build bindings using mina as a submodule in o1js repo #159

Merged
merged 23 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ba291fc
feat: change dune and cargo to build mina as a submodule
MartinMinkov Sep 28, 2023
cb91aa9
feat: copy config files from mina submodule and change paths
MartinMinkov Sep 28, 2023
26723fd
fix(test_vectors): update paths to crypto/proof-systems in dump-test-…
MartinMinkov Oct 2, 2023
2ca7383
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov Oct 26, 2023
469231d
refactor(dune): update relative paths for proof-systems and kimchi_bi…
MartinMinkov Oct 27, 2023
631edb5
fix(build-snarkyjs-web.sh, update-snarkyjs-bindings.sh): change SNARK…
MartinMinkov Oct 27, 2023
3f2ccd8
fix(dump-test-vectors.sh): change 'b10' to 'hex' in cargo run command…
MartinMinkov Oct 27, 2023
634f2ab
feat(kimchi): remove kimchi, since it's been moved to mina repo
MartinMinkov Nov 14, 2023
6529e3d
feat: support compiling kimchi from mina repo
MartinMinkov Nov 14, 2023
a702f05
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov Nov 14, 2023
98eb83e
fix(lint.yaml): remove redundant prettier check
MartinMinkov Nov 14, 2023
7ea6187
fix(CODEOWNERS): remove kimchi directory from CODEOWNERS file as it n…
MartinMinkov Nov 15, 2023
c111dca
docs(README.md): remove '/kimchi' directory description as it is no l…
MartinMinkov Dec 13, 2023
7cffd8b
feat: fix scripts for o1js building
MartinMinkov Dec 13, 2023
a1c20d5
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov Dec 13, 2023
4b453f0
chore: update bindings
MartinMinkov Dec 13, 2023
05d5665
feat(build-snarkyjs-node-artifacts.sh): add dune build command for co…
MartinMinkov Dec 13, 2023
225dd0a
chore: update bindings
MartinMinkov Dec 13, 2023
9669d55
Merge branch 'main' into feat/mina-submodule-support
MartinMinkov Dec 14, 2023
58d78b5
move kimchi/{wasm,js} to kimchi_bindings
mitschabaude Dec 18, 2023
b30b566
Merge branch 'main' into feat/mina-submodule-support
mitschabaude Dec 19, 2023
dd2e7e9
fix build scripts
mitschabaude Dec 19, 2023
15b2761
add script to help with dune build
mitschabaude Dec 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ jobs:
run: |
npm init -y
npm i prettier
npx prettier -c kimchi/js/**/*.js js/**/*.js
6 changes: 3 additions & 3 deletions crypto/test_vectors/dump-test-vectors.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

set -e

pushd ../../../../../crypto/proof-systems/poseidon/export_test_vectors
cargo run -p export_test_vectors -- hex kimchi ../../../../snarkyjs/src/bindings/crypto/test_vectors/testVectors.json
cargo run -p export_test_vectors -- hex legacy ../../../../snarkyjs/src/bindings/crypto/test_vectors/testVectorsLegacy.json
pushd ../../../mina/src/lib/crypto/proof-systems/poseidon/export_test_vectors
cargo run -p export_test_vectors -- hex kimchi ../../../../../../../bindings/crypto/test_vectors/testVectors.json
cargo run -p export_test_vectors -- hex legacy ../../../../../../../bindings/crypto/test_vectors/testVectorsLegacy.json
popd

echo "// @gen this file is generated - don't edit it directly" > $1
Expand Down
4 changes: 2 additions & 2 deletions crypto/test_vectors/dune
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
(<> %{env:NO_JS_BUILD=0} 1))
(deps
(:script ./dump-test-vectors.sh)
(source_tree ../../../../../crypto/proof-systems)
(source_tree ../../../mina/src/lib/crypto/proof-systems)
../../../../.prettierrc.cjs
(glob_files ../../../../node_modules/prettier/*))
(action
(progn
(run chmod -R +w ../../../../../crypto/proof-systems/ .)
(run chmod -R +w ../../../mina/src/lib/crypto/proof-systems/ .)
(run %{script} poseidonKimchi.ts poseidonLegacy.ts))))
28 changes: 0 additions & 28 deletions kimchi/js/README.md

This file was deleted.

50 changes: 0 additions & 50 deletions kimchi/js/bindings-bigint256.js

This file was deleted.

118 changes: 0 additions & 118 deletions kimchi/js/bindings-curve.js

This file was deleted.

Loading