[develop] Add support to build bindings using mina as a submodule in o1js repo #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vectors.sh and dune files feat(dump-test-vectors.sh): add debug statements to print current working directory for better troubleshooting fix(dune): update chmod command to reflect new path to crypto/proof-systems for correct permissions setting
…Y_JS_PATH from src/lib/snarkyjs to .
…s to correctly export test vectors in hexadecimal format
…o longer exists in the project
…onger part of the project structure
MartinMinkov
requested review from
a team,
bkase,
mitschabaude and
mrmr1993
as code owners
…nfig.mlh to ensure it's up-to-date before copying to SNARKY_JS_PATH/src
This was referenced Dec 13, 2023
mitschabaude
approved these changes
Dec 14, 2023
| @@ -51,7 +51,7 @@ | |||
| (modules snarky_js_types) | |||
| (link_flags (-linkall)) | |||
| (modes native) | |||
| (libraries mina_base fields_derivers_zkapps yojson) | |||
There was a problem hiding this comment.
I would have done this in a different commit than the one udpating the artefacts.
| @@ -20,6 +20,7 @@ | |||
| pickles_base | |||
| pickles.limb_vector | |||
| pickles_types | |||
| key_cache | |||
| @@ -34,7 +35,7 @@ | |||
| data_hash_lib | |||
| hash_prefixes | |||
| fields_derivers | |||
| fields_derivers_zkapps | |||
| fields_derivers.zkapps | |||
| @@ -3,13 +3,8 @@ | |||
| set -e | |||
|
|
|||
| pushd ../../../mina/src/lib/crypto/proof-systems/poseidon/export_test_vectors | |||
| <<<<<<< HEAD | |||
| @@ -9,7 +9,6 @@ The repo is included as a git submodule in the [o1js repo](https://github.com/o1 | |||
| - `/compiled` - compiled JS and Wasm artifacts produced by `js_of_ocaml` and `wasm-bindgen` from Rust and OCaml source code. We keep these artifacts in the source tree so that developing on o1js can be done with standard JS tooling and doesn't require setting up the full OCaml/Rust build pipeline. | |||
| - `/crypto` - pure TS implementations of a subset of the crypto primitives we use, including finite field and elliptic curve arithmetic. This is used by mina-signer (a pure TS package) to hash and sign transactions. | |||
| - `/js` - JS-side wrappers for the artifacts located in `/compiled`, which differs between the Node.js and web versions of o1js. Includes code for setting up workers to support using `rayon` in Rust. | |||
| - `/kimchi` - bindings to the [Kimchi proof system](https://o1-labs.github.io/proof-systems/kimchi/overview.html) which is implemented in Rust. This contains a Wasm compatibility layer written in Rust as well as a `js_of_ocaml`-to-`wasm-bindgen` glue layer written in JS. | |||
There was a problem hiding this comment.
More changes have to be made in this file I think, for instance the build instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses o1-labs/o1js#1096
🔗 Mina: MinaProtocol/mina#14649
🔗 o1js: o1-labs/o1js#1318
This PR makes mina buildable as a submodule of o1js. To do so, the following changes have been made:
kimchiinto mina repo.snarkyjssubmodule in the mina repo with an o1js stub module with the same dependencies as o1js, but just checks compiling. This test ensures o1js can be compiled if anything changes in the mina repo.kimchi