Readme and repo grooming, release 0.14 #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
changed the title
mitschabaude
commented
Oct 31, 2023
src/examples/plain-html/index.html
Outdated
There was a problem hiding this comment.
these files are moved here from the bindings repo. they used to be in src/bindings/compiled/web_bindings which is completely the wrong place for test/example files
mitschabaude
commented
Oct 31, 2023
| @@ -53,19 +52,18 @@ | |||
| "build:web": "rimraf ./dist/web && node src/build/buildWeb.js", | |||
| "build:examples": "rimraf ./dist/examples && npx tsc -p tsconfig.examples.json || exit 0", | |||
| "build:docs": "npx typedoc", | |||
| "serve:web": "cp src/bindings/compiled/web_bindings/server.js src/bindings/compiled/web_bindings/index.html src/examples/simple_zkapp.js dist/web && node dist/web/server.js", | |||
There was a problem hiding this comment.
removed a couple scripts here that, to my knowledge, aren't used
Trivo25
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small things lumped together
README-dev.mdwas outdated in two places, this updates itbindings: o1-labs/o1js-bindings#196