Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: parallelising kimchi prover more #2969

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Jan 27, 2025

A bunch of performance improvements to the kimchi prover aiming to utilise more parallelism where available.

As of now, the save-up seems to be as follows:
screen_2025-01-29_001

TODOs:

  • Check how much faster it is on mina side. Adjust the benchmark if necessary (more columns? lookups?)
  • Make sure there are no regressions for the verifier side.
  • Check if parallel evaluations can be faster -- do we need to clone the vector and then interpolate?
  • Check that perm_aggreg optimisation preserves correctness
  • Last step: run the threading profiler once again to make sure I didn't miss anything

@volhovm volhovm force-pushed the volhovm/profiling-kimchi-thread-utilisation branch 3 times, most recently from 3b55d05 to d2212e8 Compare January 27, 2025 13:49
@volhovm volhovm force-pushed the volhovm/profiling-kimchi-thread-utilisation branch 21 times, most recently from f4c37e6 to 01dfdbc Compare January 29, 2025 14:08
@volhovm volhovm force-pushed the volhovm/profiling-kimchi-thread-utilisation branch from 01dfdbc to fe029f4 Compare January 29, 2025 14:20
@volhovm volhovm force-pushed the volhovm/profiling-kimchi-thread-utilisation branch from fe029f4 to f8ddd85 Compare January 29, 2025 14:53
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 97.11934% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.93%. Comparing base (fe10025) to head (f8ddd85).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
kimchi/src/prover.rs 84.78% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
+ Coverage   76.85%   76.93%   +0.08%     
==========================================
  Files         258      261       +3     
  Lines       61202    61569     +367     
==========================================
+ Hits        47036    47370     +334     
- Misses      14166    14199      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant