Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error message when docker ps -a command fails #712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DeMonkeyCoder
Copy link

Currently, when the docker ps -a command fails, the CLI displays a generic error message that does not clearly indicate the underlying issue, making debugging difficult. For instance, in my case, the Docker Engine was running but encountered permission issues. The generic error message left me confused until I manually ran docker ps -a in the shell, which provided the actual error details.

@shimkiv
Copy link
Member

shimkiv commented Dec 20, 2024

Hey @DeMonkeyCoder,
in order to debug the involved commands execution results you can set the DEBUG envar, for example: DEBUG=zk:* zk lightnet ....
If this is not sufficient, then instead of your current approach I'd better come up with more generalized permissions checking step rather than updating specific command.

@DeMonkeyCoder
Copy link
Author

Hey @DeMonkeyCoder, in order to debug the involved commands execution results you can set the DEBUG envar, for example: DEBUG=zk:* zk lightnet .... If this is not sufficient, then instead of your current approach I'd better come up with more generalized permissions checking step rather than updating specific command.

I think the best way to do this is to check if stderr includes 'permission denied,' because checking if the user is a member of the Docker group is not enough, as the group permissions might not take effect until after restarting.

@shimkiv
Copy link
Member

shimkiv commented Dec 23, 2024

@DeMonkeyCoder I'd say it will be better to simply outline the possibility of enabling the debug logging (for the lightnet subcommand only at this stage) in this repository's README.md file and/or reflect the same info in https://github.com/o1-labs/docs2/blob/main/docs/zkapps/writing-a-zkapp/introduction-to-zkapps/testing-zkapps-lightnet.mdx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants