Convert to Slash Commands #7
Conversation
- constants moved to constants.py file - create an overall "bot" directory - renamed lovelace.py to bot.py
Lovelace is now a package! It requires a different command to run, the README is updated. There is now an overaching bot directory folder with appropriate __init__ and __main__ files. Additionally, there are two new folder strucutres: exts and utils. exts is for Extensions while util is for utility functions and classes. Functionality for autoloading extensions was also added. It checks if a setup function is in the file, if yes than it'll load in the extension.
bot/__main__.py
Outdated
| from bot import exts | ||
| from bot.bot import bot | ||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Truthfully, I think this is a bit too "cute" and magical. It would be better™ to just import the packages and then call .setup() on them, or have a "extensions" array (and then iterate over them and call .setup() on them.
There was a problem hiding this comment.
I purposely went with a more "magical" method because I didn't want to have an extensions array we'd have to adjust and change with each extension added. Do you think it'd be better to have call out the different extensions and load them individually? @travigd
There was a problem hiding this comment.
It's prooooooobably fine. Java land does this a bunch with their auto-wired beans.
That being said, I do think it's better to just have an array where you specify all of them explicitly.
Co-authored-by: Travis DePrato <[email protected]>
I've simplified the bot set-up and made it not a module to make sure that setting it up locally for contributions is easier. The other big change is the less-smart, but more-readable/understandable method of loading extensions. If a new extenion is added it must be manually added to Lovelace's `__init__()`. These changes are also made in preperation for adding in slash commands.
This adds in the Dockerfile to run a basic instance of this bot. It takes the bot Token as an ENV argument. Eventually this should be changed to use a proper secrets file / vault.
This probably-too-large commit is a complete overhaul of the affinity and working group commands to use Slash Commands instead. Overall, the previous `!` commands were removed and instead replaced with the slash commands response. It makes some assumptions about the server setup and reduces some of the code complexity and constants required. With this includes a file to register and update the slash commands.
With the bot simplication, this removes files that are no longer used.
janine9vn
dismissed
twavv’s stale review
Substantial changes, this PR should be re-reviewed
It's been awhile and this now looks drastically different!
BLUF
This PR completely removes the
!join_ag!join_wg` commands. Instead, it implements slash command functionality.Slash Commands provide a better user experience and are easier to parse with the setup.
There are many changes to allow this to happen but most of them involve replacing functionality 1:1 or removing code that is no longer needed.
Docker
This PR also introduces Docker. Lovelace is currently running in an Azure Container Instance. Once this PR is merged and the Dockerfile gets added to the repository, I can begin looking at setting up CI/CD with Azure Containers.