[engine] Fix typo for database function name #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupondje
requested review from
dupondje
and removed request for
emesika and
mwperina
dupondje
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Thanks for the change.
Could you just adjust the commit message?
As this is a change on the 'core' component, can you use.
core: fix typo in RoleDao
All our commits are prepended by the component, then a :, and some small info.
Check the history of the touched files to have some examples :)
This way we keep the commit messages a bit the same style. Otherwise it will become a mess.
And then some small message in the commit message?
From the initiation of the project there was typo in the database function with name 'GetRolsByid'. This changes just rename this function to more correct 'GetRoleByid' and change it at the calling side in the DAO layer. Signed-off-by: Stanislav Melnichuk <[email protected]>
0ffer
force-pushed
the
bugfix/typo-rols
branch
from
a44c156 to
98a5002
Compare
|
Yep, sorry, I forget about this 🥲 I fixed message for the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Just fix small typo in database function name.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y/n]
yes