Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrong shuffle feature id #2421

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: Wrong shuffle feature id #2421

merged 1 commit into from
Nov 22, 2023

Conversation

yaraslau-kavaliou
Copy link
Contributor

Related incident - https://oat-sa.atlassian.net/browse/OATSD-2958

After the fix the shuffle feature is enabled for Simple Choice interaction even though allowElimination feature is disabled.

Screenshot from 2023-11-22 12-46-09

@github-actions GitHub Actions
Copy link

Version

Target Version 30.3.4
Last version 30.3.3

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@siwane
Copy link
Collaborator

siwane commented Nov 22, 2023

Master PR :p !
Do you know which config it relies on?

@yaraslau-kavaliou yaraslau-kavaliou mentioned this pull request Nov 22, 2023
Merged
@yaraslau-kavaliou yaraslau-kavaliou merged commit c9683fa into develop Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siwane siwane siwane approved these changes

@shaveko shaveko Awaiting requested review from shaveko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaraslau-kavaliou @siwane