fix: ruby tags focus and navigation #2655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
viktar-dzmitryieu-tao
requested review from
a team,
tikhanovichA,
KirylHatalski and
Karol-Stelmaczonek
and removed request for
a team
tikhanovichA
approved these changes
Jan 10, 2025
olga-kulish
reviewed
Jan 13, 2025
|
|
||
| ruby rt { | ||
| // Chrome >=128 and Firefox support | ||
| ruby-align: start; |
There was a problem hiding this comment.
I don't think we should do it. I understand that while you are typing ruby, cursor position is weird, but:
Or at least do not apply ruby-align in test-runner (see Item Preview in the playground). These customers still use CurrentGen test-runner.
Also, if you decide to keep this, could you please add this style for A-block too, not only for Prompt?
There was a problem hiding this comment.
I'll close this PR as it was not required and can lead to misunderstanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/INF-279
What's Changed
How to test
<rt>content is aligned to the beginning of the elementDeployed to https://test-viktar-authoring.v3.playground.taocloud.org/tao/Main/login