Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing syntax throwing an error #412

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

uncleempty
Copy link
Contributor

It is there to fix a small problem, introduced in one of the previous PRs.

As per the customer report, it shows syntax errors when trying to run the command from the SDK readme:

./vendor/bin/qtisdk render -df --source /Users/*/Downloads/i6422d9afb42b32279aab31294164637a8/qti.xml --flavour goldilocks > ./qti.html
PHP Parse error:  syntax error, unexpected token "{" in /Users/*/Downloads/test/taoApi/vendor/qtism/qtism/src/qtism/cli/Render.php on line 283

Which is pretty logical, since variable interpolation won't work outside of "string context".

@wazelin
Copy link
Member

wazelin commented Feb 5, 2025

Ooh. This is pretty bad.
Thank you for the fix, @uncleempty!

Luckily, this issue concerns only the CLI part of the library. Merging and releasing should be sufficient. No need to deploy this anywhere.

@uncleempty uncleempty merged commit 11ab462 into develop Feb 5, 2025
6 of 7 checks passed
@uncleempty uncleempty deleted the fix/interpolation-syntax branch February 5, 2025 20:46
@bugalot
Copy link
Contributor

bugalot commented Feb 6, 2025

Thanks for this! You might also want to consider upgrading wp-cli as in the following PR (that I never merged)
CC @wazelin / @uncleempty #408

@bugalot
Copy link
Contributor

bugalot commented Feb 6, 2025

as well as the usage of relative paths in that exact command, which would be nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants