Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'Add All Unknown Status Types' now sorts new statuses by symbol #2384

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

claremacrae
Copy link
Collaborator

Description

The Tasks-Demo vault has loads of unknown statuses, because of all the sample files for the different supported Themes and CSS Snippet.

I found when clicking Add All Unknown Status Types' that I couldn't see the statuses I was looking for, because the order they were added was seemingly random.

This change uses locale-aware sorting to sort the new statuses by their symbol.

The documentation is updated too.

Motivation and Context

See above.

How has this been tested?

  • Updating an existing test.
  • Manual testing in the demo vualt.

Screenshots (if appropriate)

Before

image

After

image

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

This makes it a lot easier to understand the new statuses,
and should make it easier to edit them too.
@claremacrae claremacrae added the scope: task states Requests relating to custom task states, like 'in-progress', for example, and state transitions label Oct 29, 2023
@claremacrae claremacrae merged commit a26bd4b into main Oct 29, 2023
@claremacrae claremacrae deleted the sort-unknown-statuses branch October 29, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: task states Requests relating to custom task states, like 'in-progress', for example, and state transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant