Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle any hidden VS16 character on all emojis #3193

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

claremacrae
Copy link
Collaborator

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Tasks can now cope with any emojis being followed by VS16 Variation Selectors, not just priorities and depends-on.

Motivation and Context

Fix #3179

How has this been tested?

  • Automated tests
  • Exploratory testing

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae added the scope: parsing markdown See also 'scope: global filter' label Nov 21, 2024
@claremacrae claremacrae merged commit bad833e into main Nov 21, 2024
3 checks passed
@claremacrae claremacrae deleted the fix-variant-selectors branch November 21, 2024 18:05
@claremacrae
Copy link
Collaborator Author

The data used in the exploratory testing was:

- [ ] #task test - no VS16 ⏳ 2024-11-18
- [ ] #task test - has VS16 ⏳️ 2024-11-18

```tasks
path includes {{query.file.path}}
group by scheduled
```

Before the fix:

image

After the fix:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: parsing markdown See also 'scope: global filter'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode Variant selectors on some emojis work, while others are parsed incorrectly
1 participant