refactor: Add ListItem methods findClosestParentTask() and isTask() #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that whilst the tests pass, the Tasks plugin does not load. It crashes at startup, giving this console error: Plugin failure: obsidian-tasks-plugin TypeError: Class extends value undefined is not a constructor or null
…tem.ts This enables the Tasks plugin to load again, after the previous commit.
|
|
Hi @ilandikov, the crucial step is b4f0004 🎉 |
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Description
This fixes a problem that @ilandikov and I had, where we wanted to move
findClosestParentTask()fromQueryResultsRenderer.tstoListItem.ts, but when we did so, the Tasks plugin crashed on start-up.It is more convenient to be able to to write
listItem.findClosestParentTask()and that now works.I thought that the
isTaskaccessor would be needed to make this work, but in fact it wasn't needed. However, it may still be useful eventually in custom filters and groups.Motivation and Context
Move code to a more logical place.
How has this been tested?
Parent-Child relationships - Searches - Tasks.mdcorrectlyChecklist
yarn run lint.Terms