Update clang-format to 16 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RytoEX
approved these changes
Jan 10, 2024
|
Commits need to be squashed and the experimental change reverted before that. |
Ah, I didn't see the commits. Yes, this feedback needs to be addressed. |
RytoEX
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Per @PatTheMav :
Commits need to be squashed and the experimental change reverted before that.
EZ64cool
force-pushed
the
clang-format-16
branch
2 times, most recently
from
5982252 to
e604d1f
Compare
|
Thanks, first time contributing so sorry for the mess. I'll make a seperate FQ for running clang-format on other relevant files to keep this neat. |
With a recent commit to .clang-format the minimum required version has now increased to 16. Without this clang-format will throw an error of ".clang-format:115:3: error: unknown enumerated scalar"
EZ64cool
force-pushed
the
clang-format-16
branch
from
e604d1f to
c245102
Compare
PatTheMav
approved these changes
Jan 10, 2024
RytoEX
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade clang-format used in actions to 16
Motivation and Context
With changes introduced in #82 clang-format 16 is now required. Using the current version of 13 will result in a
.clang-format:115:3: error: unknown enumerated scalarerrorHow Has This Been Tested?
I have made small edits to code files which should trigger the github action which I will then revert.
I have also implemented this change into my own plugin after merging latest. https://github.com/EZ64cool/obs-hadowplay/actions/workflows/pr-pull.yaml?query=branch%3Amerging_template
Types of changes
Checklist: