-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Remove Qt version selection and Qt 5 support #119
Conversation
cc @gxalpha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth to update the template itself to not use find_qt
itself (but the normal find_package
call for Qt) but retain the function to not immediately break all plugins that just fetch&merge upstream changes.
As far as I can tell from the linked obs-studio PR, we continued to use |
We use |
Hmm. Why do we still define the macro in non-legacy CMake? To avoid breakage at the time? |
That said, I can certainly remove it entirely from here if obs-plugintemplate has no notion of legacy/modern CMake. |
Correct, at first neither |
Co-authored-by: gxalpha <[email protected]>
We currently no longer need this functionality.
I've pushed a second commit that outright removes |
Description
This is a port of obsproject/obs-studio#9263 (obsproject/obs-studio@9d611a0).
This does not remove
find_qt
, but just forces it to Qt 6 for now.Motivation and Context
We no longer support building OBS Studio with Qt 5.
How Has This Been Tested?
I haven't tested this, This is a port of an existing commit, which has been tested.
Types of changes
Checklist: