Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix random password generation for macOS codesigning #99

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

paulpv
Copy link
Contributor

@paulpv paulpv commented Nov 13, 2023

sha1sum is part of Homebrew's coreutils, but macOS ships with shasum by default, which supports many variants and defaults to SHA-1 by default.
This is essentially a cherry-pick of:
obsproject/obs-studio@1e74256

Description

Build is outputting this error:

Run : macOS Codesigning ✍️
/Users/runner/work/_temp/f1d2ceff-9fa3-45ff-9e47-d545a0f36982:12: command not found: sha1sum

Motivation and Context

@PatTheMav noticed this in the OBS build and fixed it there:
obsproject/obs-studio@1e74256
Doing the same here.

How Has This Been Tested?

Build no longer outputs:

Run : macOS Codesigning ✍️
/Users/runner/work/_temp/f1d2ceff-9fa3-45ff-9e47-d545a0f36982:12: command not found: sha1sum

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

`sha1sum` is part of Homebrew's coreutils, but macOS ships with
`shasum` by default, which supports many variants and defaults to
SHA-1 by default.
This is essentially a cherry-pick of:
obsproject/obs-studio@1e74256
@PatTheMav PatTheMav merged commit db606e8 into obsproject:master Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants