Alternative effects API #3461
Open
Alternative effects API #3461
+2,795
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
force-pushed
the
dkalinichenko/alt-effects-api
branch
from
5af0547 to
021550e
Compare
dkalinichenko-js
force-pushed
the
dkalinichenko/alt-effects-api
branch
from
021550e to
609e6e3
Compare
dkalinichenko-js
force-pushed
the
dkalinichenko/alt-effects-api
branch
from
609e6e3 to
2a288ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative effects API, ported from https://github.com/lpw25/alternative-effects-api. I reviewed the original and made some changes, but kept the design intact. Local continuations are yet unsupported. Portable continuations are yet unsupported, to be added soon.
Yieldingannotations are not yet present, to be added afterlocalstarts implyingyielding.Best reviewed commit by commit. Most of them do not contain substantive changes. The two important ones are:
last_fiberparameter. Here, I copied the approach from Stdlib.Handler.tin aglobal_record and comments out functions related to local continuations. Also does some other refactoring.