Add a dummy caml_debugger_saved_instruction when HAS_SOCKETS is false
#13719
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alse The `caml_debugger_saved_instruction` function is called unconditionally in `runtime/interp.c` to implement the debugger-specific instructions. This patch provides a dummy implementation for that function, alongside the other `caml_debugger_*` functions, so that the interpreter can be built in the uncommon setups with no available socket implementation.
dra27
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
There's also caml_debugger_code_unloaded, although looking at #8654, I can't tell where/how that function's intended to be used (@jhjourdan?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
caml_debugger_saved_instructionfunction is called unconditionally inruntime/interp.cto implement the debugger-specific instructions. This patch provides a dummy implementation for that function, alongside the othercaml_debugger_*functions, so that the interpreter can be built in the uncommon setups with no available socket implementation.This was encountered while building a compiler for MirageOS.
This doesn’t require a changelog entry.