-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add booster for rewards #867
Conversation
/** | ||
* @notice Batch Mint only for owner | ||
*/ | ||
function batchCreateBoosts(address[] memory user,string[] memory tokenURI) external onlyOwner |
Check notice
Code scanning / Slither
Local variable shadowing Low
- Booster.tokenURI(uint256) (function)
- ERC721URIStorage.tokenURI(uint256) (function)
- ERC721.tokenURI(uint256) (function)
- IERC721Metadata.tokenURI(uint256) (function)
return newItemId; | ||
} | ||
|
||
function createBoost(address user, string memory tokenURI) external onlyOwner returns (uint256) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
- Booster.tokenURI(uint256) (function)
- ERC721URIStorage.tokenURI(uint256) (function)
- ERC721.tokenURI(uint256) (function)
- IERC721Metadata.tokenURI(uint256) (function)
using Counters for Counters.Counter; | ||
Counters.Counter private _tokenIds; | ||
uint256 public boost; | ||
constructor(string memory _name, string memory _symbol,uint256 _boost) |
Check notice
Code scanning / Slither
Local variable shadowing Low
using Counters for Counters.Counter; | ||
Counters.Counter private _tokenIds; | ||
uint256 public boost; | ||
constructor(string memory _name, string memory _symbol,uint256 _boost) |
Check notice
Code scanning / Slither
Local variable shadowing Low
super._beforeTokenTransfer(from, to, tokenId, batchSize); | ||
} | ||
|
||
function _createBoost(address user, string memory tokenURI) private returns (uint256) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
- Booster.tokenURI(uint256) (function)
- ERC721URIStorage.tokenURI(uint256) (function)
- ERC721.tokenURI(uint256) (function)
- IERC721Metadata.tokenURI(uint256) (function)
contracts/rewards/Booster.sol
Outdated
function _burn(uint256 tokenId) internal override(ERC721URIStorage,ERC721) { | ||
revert("Burning not allowed"); | ||
} |
Check warning
Code scanning / Slither
Dead-code Warning
add booster for rewards
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments that I gave for the access list pr
Add booster contract for upcoming node rewards