Feature/escrow_payments #828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcos20
requested review from
bogdanfazakas,
jamiehewitt15,
mariacarmina and
paulo-ocean
as code owners
mariacarmina
reviewed
Feb 6, 2025
| console.log(env.fees) | ||
| for (const fee of env.fees[chainId]) { | ||
| console.log(fee) | ||
| console.log(fee.feeToken) |
There was a problem hiding this comment.
Are these console.logs for debug only? If yes, maybe we can log them using PROVIDER_LOGGER and set the log level to 'debug'. These might help in the future if issues occur.
| const signer = blockchain.getSigner() | ||
| const contract = await this.getContract(chainId, signer) | ||
| try { | ||
| return await contract.getAuthorizations(token, payer, payee) |
There was a problem hiding this comment.
Those functions, at least most of them are implemented here, when a new ocean.js version will be released, I would say that contract object creation and calling contract function to be replaced with the methods in ocean.js. In ocean.js I can also add the additional checks that you managed to write within ocean-node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How to use:
export CONTRACTS_VERSION=escrow ./start_ocean.sh --no-aquarius --no-provider --no-dashboard --with-typesenseNice TODOs (can be done later):