Jekyll3 #24
Open
Jekyll3 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parkr: can you review and merge this? Not sure all the patches in this PR are needed. I only saw the |
|
Looks like Travis is having a tough time with our current configuration, and octopress-multilingual is causing issues as well. Oh, fun. |
| end | ||
| else | ||
| page.site.collections[page['paginate']['collection']].docs | ||
| end | ||
|
|
||
| if categories = page.data['paginate']['categories'] | ||
| collection = collection.reject{|p| (p.categories & categories).empty?} | ||
| collection = collection.reject{|p| (p.data['categories'] & categories).empty?} |
There was a problem hiding this comment.
@XhmikosR I think these p.data changes are still required.
There was a problem hiding this comment.
Can it be because I don't use categories so that code isn't run at all?
|
@parkr: do you need any help with this? I can try rebasing the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following adds support for Jekyll 3 and removes some deprecation warnings.