Upgrade File Access to DocumentFile for Scoped Storage Compatibility #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!instanceFolder.exists() && !instanceFolder.mkdirs()) { | ||
| throw new Exception("Should have been able to create " + instanceFolder.getPath()); | ||
| } | ||
| assertTrue(instanceFolder.exists()); | ||
| FileOutputStream f = new FileOutputStream(new File(instanceFolder.getPath() + "/temp")); | ||
| f.write(new byte[] { 97, 98, 99 }); | ||
| File tempFile = new File(instanceFolder, "temp"); |
There was a problem hiding this comment.
@wbrunette what do you think, please. Although he converted the File object to a DocumentFile in line 1580
There was a problem hiding this comment.
You are correct,
There are other ways to create a DocumentFile such as fromSingleUri
OutputStream outputStream = context.getContentResolver().openOutputStream(newFile.getUri());
if (outputStream != null) {
outputStream.write(content.getBytes());
outputStream.close();
}
| FileManifestDocument tableManifestEntries = | ||
| synchronizer.getAppLevelFileManifest(null, null, true); | ||
| synchronizer.getAppLevelFileManifest(String.valueOf(nullFiles), null, true); |
There was a problem hiding this comment.
why did you use this String.valueOf(nullFiles), please?
| "sample.jpg"); | ||
| DocumentFile configFile = DocumentFile.fromFile( | ||
| new File(ODKFileUtils.getAssetsCsvInstanceFolder(getAppName(), tableId, rowIdFullCommon), | ||
| "sample.jpg")); | ||
| cvValues.put("col6", ODKFileUtils.asConfigRelativePath(getAppName(), configFile)); // configpath | ||
| File rowFile = new File(ODKFileUtils.getInstanceFolder(getAppName(), tableId, rowIdFullCommon), "sample.jpg"); |
There was a problem hiding this comment.
I think you skipped this
| @@ -529,7 +531,7 @@ public void syncTableLevelFiles(String tableId, String serverReportedTableLevelE | |||
|
|
|||
| for (OdkTablesFileManifestEntry entry : manifestDocument.entries) { | |||
| File localFile = ODKFileUtils.asConfigFile(sc.getAppName(), entry.filename); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.