Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/verbs: Fix data race vrb_open_ep function #10571

Merged
merged 1 commit into from
Dec 2, 2024
Merged

prov/verbs: Fix data race vrb_open_ep function #10571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions prov/verbs/src/verbs_ep.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ ssize_t vrb_post_send(struct vrb_ep *ep, struct ibv_send_wr *wr, uint64_t flags)
}

if (vrb_wr_consumes_recv(wr)) {
if (!ep->peer_rq_credits ||
if (!ep->peer_rq_credits ||
(ep->peer_rq_credits == 1 && !(flags & OFI_PRIORITY)))
/* Last credit is reserved for credit update */
goto freectx;
Expand Down Expand Up @@ -1161,7 +1161,7 @@ static struct fi_ops vrb_ep_ops = {
.close = vrb_ep_close,
.bind = vrb_ep_bind,
.control = vrb_ep_control,
.ops_open = fi_no_ops_open,
.ops_open = vrb_ep_ops_open,
};

static struct fi_ops_cm vrb_dgram_cm_ops = {
Expand Down Expand Up @@ -1394,7 +1394,6 @@ int vrb_open_ep(struct fid_domain *domain, struct fi_info *info,
*ep_fid = &ep->util_ep.ep_fid;
ep->util_ep.ep_fid.fid.ops = &vrb_ep_ops;
ep->util_ep.ep_fid.ops = &vrb_ep_base_ops;
(*ep_fid)->fid.ops->ops_open = vrb_ep_ops_open;

vrb_prof_func_end("vrb_open_ep");

Expand Down