prov/tcp: implement FI_FIREWALL_ADDR for AV inserts #10724
Draft
+46
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooststep
force-pushed
the
av-no-connect
branch
from
903879e to
0399693
Compare
shefty
reviewed
Jan 29, 2025
FI_FIREWALL_ADDR indicates to the provider that the inserted addresses may be restricted by a firewall Signed-off-by: Stephen Oost <[email protected]>
Signed-off-by: Stephen Oost <[email protected]>
ooststep
force-pushed
the
av-no-connect
branch
from
0399693 to
fb9a9bb
Compare
ooststep
changed the title
shefty
reviewed
Feb 5, 2025
| peer = node->data; | ||
| peer->refcnt++; | ||
| *peer = node->data; | ||
| (*peer)->refcnt++; |
There was a problem hiding this comment.
Set ret = FI_SUCCESS here to avoid an extra branch on return.
There was a problem hiding this comment.
Something is off in the flag settings. A peer might be inserted in response to a connection request (xnet_process_connreq). In that case, peer->av_flags = 0. When an address is inserted with FI_FIREWALL_ADDR, the peer will be found, but peer->av_flags won't be adjusted.
I think you need (*peer)->av_flags |= flags; here.
| *peer = rxm_alloc_peer(av, addr); | ||
| if (!*peer) | ||
| ret = -FI_ENOMEM; | ||
| (*peer)->av_flags = flags; |
There was a problem hiding this comment.
Needs to be part of an else, or this results in a crash.
| struct util_peer_addr * | ||
| util_get_peer(struct rxm_av *av, const void *addr) | ||
|
|
||
| int util_get_peer(struct rxm_av *av, const void *addr, struct util_peer_addr **peer, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
fi_av_insertflag,FI_FIREWALL_ADDR, which indicates that an av insert should fail if there is not already an established connection to the peer and the provider has no means to circumvent the firewall. The PR also implements the functionality for the TCP provider (and RXM provider, though this is not the primary goal).I do still need to add a fabtest for the feature but wanted to push this up for initial review in the meantime.
resolves #10637
replaces #10534